golang-codereviews - Google Groups (original) (raw)
0 selected
Ian Alexander (Gerrit), Michael Matloob (Gerrit)5
9:42 PM
[go] cmd/link: fix copying directory when symlink failsAttention needed from Ian Alexander Michael Matloob voted Code-Review+1 Code-Review +1 Open in Gerrit
unread,
[go] cmd/link: fix copying directory when symlink failsAttention needed from Ian Alexander Michael Matloob voted Code-Review+1 Code-Review +1 Open in Gerrit
9:42 PM
David Finkel (Gerrit), … Gopher Robot (Gerrit)18
9:04 PM
[go] cmd/go: add support for git sha256 hashesDavid Finkel added 1 comment Patchset-level comments File-level comment, Patchset 2: Michael Matloob
unread,
[go] cmd/go: add support for git sha256 hashesDavid Finkel added 1 comment Patchset-level comments File-level comment, Patchset 2: Michael Matloob
9:04 PM
David Finkel (Gerrit)
9:02 PM
[go] cmd/go: add a script test for git sha256 fetchingAttention needed from Michael Matloob and Sam Thanawalla David Finkel has uploaded the change for
unread,
[go] cmd/go: add a script test for git sha256 fetchingAttention needed from Michael Matloob and Sam Thanawalla David Finkel has uploaded the change for
9:02 PM
Gerrit Bot (Gerrit), … 黄志文 (Gerrit)7
9:00 PM
[go] text/template: use sync.OnceValue for builtinFuncs黄志文 added 1 comment File src/text/template/funcs.go Line 66, Patchset 1 (Latest): var
unread,
[go] text/template: use sync.OnceValue for builtinFuncs黄志文 added 1 comment File src/text/template/funcs.go Line 66, Patchset 1 (Latest): var
9:00 PM
Meidan Li (Gerrit), … abner chenc (Gerrit)13
8:41 PM
[go] internal/bytealg: optimize the function compare using SIMD on loong64abner chenc submitted the change Change information Commit message: internal/bytealg: optimize the
unread,
[go] internal/bytealg: optimize the function compare using SIMD on loong64abner chenc submitted the change Change information Commit message: internal/bytealg: optimize the
8:41 PM
David Chase (Gerrit), Junyang Shao (Gerrit)7
8:28 PM
[go] cmd/compile: more adapters for simdAttention needed from David Chase, Keith Randall, Martin Möhrmann and Robert Griesemer Junyang Shao
unread,
[go] cmd/compile: more adapters for simdAttention needed from David Chase, Keith Randall, Martin Möhrmann and Robert Griesemer Junyang Shao
8:28 PM
Michael Pratt (Gerrit)2
8:20 PM
[go] WIP: internal/runtime/cgroup: CPU cgroup discoveryAttention needed from Carlos Amedee and Michael Knyszek Michael Pratt added 1 comment File src/
unread,
[go] WIP: internal/runtime/cgroup: CPU cgroup discoveryAttention needed from Carlos Amedee and Michael Knyszek Michael Pratt added 1 comment File src/
8:20 PM
Mark Freeman (Gerrit), Robert Griesemer (Gerrit)8
7:10 PM
[go] go/types, types2: improve error message for init without bodyAttention needed from Mark Freeman Robert Griesemer voted and added 1 comment Votes added by Robert
unread,
[go] go/types, types2: improve error message for init without bodyAttention needed from Mark Freeman Robert Griesemer voted and added 1 comment Votes added by Robert
7:10 PM
Damien Neil (Gerrit)
7:05 PM
[go] os: don't follow symlinks on Windows when O_CREATE|O_EXCLAttention needed from Alan Donovan New activity on the change Open in Gerrit Related details
unread,
[go] os: don't follow symlinks on Windows when O_CREATE|O_EXCLAttention needed from Alan Donovan New activity on the change Open in Gerrit Related details
7:05 PM
Jonathan Amsterdam (Gerrit), Alan Donovan (Gerrit)6
6:48 PM
[tools] internal/mcp: remove omitzeroJonathan Amsterdam submitted the change Change information Commit message: internal/mcp: remove
unread,
[tools] internal/mcp: remove omitzeroJonathan Amsterdam submitted the change Change information Commit message: internal/mcp: remove
6:48 PM
Jonathan Amsterdam (Gerrit)
6:47 PM
[tools] internal/mcp: document content constructorsAttention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change
unread,
[tools] internal/mcp: document content constructorsAttention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change
6:47 PM
Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)11
6:43 PM
[go] testing: add OutputGopher Robot submitted the change Change information Commit message: testing: add Output Output is a
unread,
[go] testing: add OutputGopher Robot submitted the change Change information Commit message: testing: add Output Output is a
6:43 PM
Junyang Shao (Gerrit), David Chase (Gerrit)10
6:30 PM
[go] cmd/compile: add VPMOVQ2M and VPMOVM2Q to ssaAttention needed from Cherry Mui, David Chase and Junyang Shao Junyang Shao uploaded new patchset
unread,
[go] cmd/compile: add VPMOVQ2M and VPMOVM2Q to ssaAttention needed from Cherry Mui, David Chase and Junyang Shao Junyang Shao uploaded new patchset
6:30 PM
Alan Donovan (Gerrit)3
6:03 PM
[tools] gopls/internal/protocol: make FoldingRange fields optionalAttention needed from Robert Findley Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit
unread,
[tools] gopls/internal/protocol: make FoldingRange fields optionalAttention needed from Robert Findley Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit
6:03 PM
Robert Findley (Gerrit), Jonathan Amsterdam (Gerrit)5
6:03 PM
[tools] internal/mcp: simplify contentJonathan Amsterdam submitted the change Change information Commit message: internal/mcp: simplify
unread,
[tools] internal/mcp: simplify contentJonathan Amsterdam submitted the change Change information Commit message: internal/mcp: simplify
6:03 PM
Michael Pratt (Gerrit), Michael Knyszek (Gerrit)4
5:58 PM
[go] internal/runtime/cgroup: add line-by-line reader using a single scratch bufferAttention needed from Michael Pratt Michael Knyszek added 6 comments File src/internal/runtime/cgroup
unread,
[go] internal/runtime/cgroup: add line-by-line reader using a single scratch bufferAttention needed from Michael Pratt Michael Knyszek added 6 comments File src/internal/runtime/cgroup
5:58 PM
Michael Pratt (Gerrit), Michael Knyszek (Gerrit)2
5:48 PM
[go] runtime: rename ncpu to numCPUStartupAttention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit
unread,
[go] runtime: rename ncpu to numCPUStartupAttention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit
5:48 PM
Michael Pratt (Gerrit), Michael Knyszek (Gerrit)2
5:46 PM
[go] internal/runtime/syscall: add basic file system callsAttention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit
unread,
[go] internal/runtime/syscall: add basic file system callsAttention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit
5:46 PM
Robert Findley (Gerrit), Jonathan Amsterdam (Gerrit)3
5:43 PM
[tools] internal/mcp: merge the protocol package into mcpRobert Findley submitted the change Change information Commit message: internal/mcp: merge the
unread,
[tools] internal/mcp: merge the protocol package into mcpRobert Findley submitted the change Change information Commit message: internal/mcp: merge the
5:43 PM
Jonathan Amsterdam (Gerrit)
5:43 PM
[tools] internal/mcp: design.md: clarify backward compatibility guaranteeAttention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change
unread,
[tools] internal/mcp: design.md: clarify backward compatibility guaranteeAttention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change
5:43 PM
Ian Alexander (Gerrit), Michael Matloob (Gerrit)2
5:35 PM
[go] cmd/go/internal/pkg: fail on bad filenamesAttention needed from Ian Alexander Michael Matloob added 2 comments File src/cmd/go/internal/load/
unread,
[go] cmd/go/internal/pkg: fail on bad filenamesAttention needed from Ian Alexander Michael Matloob added 2 comments File src/cmd/go/internal/load/
5:35 PM
Gerrit Bot (Gerrit), … Arati (Gerrit)122
5:28 PM
[go] testing: add a new output writer and use it in t.LogArati added 1 comment Patchset-level comments File-level comment, Patchset 39 (Latest): Michael
unread,
[go] testing: add a new output writer and use it in t.LogArati added 1 comment Patchset-level comments File-level comment, Patchset 39 (Latest): Michael
5:28 PM
Gerrit Bot (Gerrit), … Murali Hemanna (Gerrit)7
5:22 PM
[website] Add timestamps to default selection example for clearer visualizationMurali Hemanna added 1 comment Patchset-level comments File-level comment, Patchset 1: Gopher Robot .
unread,
[website] Add timestamps to default selection example for clearer visualizationMurali Hemanna added 1 comment Patchset-level comments File-level comment, Patchset 1: Gopher Robot .
5:22 PM
Michael Knyszek (Gerrit), … Cherry Mui (Gerrit)3
5:21 PM
[go] runtime: only update freeIndexForScan outside of the mark phaseAttention needed from Keith Randall and Michael Knyszek Cherry Mui voted Code-Review+2 Code-Review +2
unread,
[go] runtime: only update freeIndexForScan outside of the mark phaseAttention needed from Keith Randall and Michael Knyszek Cherry Mui voted Code-Review+2 Code-Review +2
5:21 PM
Quim Muntal (Gerrit), … Damien Neil (Gerrit)8
5:08 PM
[go] os: don't fallback to the Stat slow path if file doesn't exist on WindowsAttention needed from Alex Brainman, Jake Bailey and Quim Muntal Damien Neil voted and added 3
unread,
[go] os: don't fallback to the Stat slow path if file doesn't exist on WindowsAttention needed from Alex Brainman, Jake Bailey and Quim Muntal Damien Neil voted and added 3
5:08 PM
Gerrit Bot (Gerrit), … Rob Pike (Gerrit)9
5:07 PM
[go] text/template: limit expression parenthesis nestingAttention needed from Roland Shoemaker and qiu laidongfeng2 Rob Pike added 6 comments File src/text/
unread,
[go] text/template: limit expression parenthesis nestingAttention needed from Roland Shoemaker and qiu laidongfeng2 Rob Pike added 6 comments File src/text/
5:07 PM
Mark Freeman (Gerrit), Robert Griesemer (Gerrit)12
5:06 PM
[go] document stringsAttention needed from Robert Griesemer Mark Freeman added 6 comments Patchset-level comments File-
unread,
[go] document stringsAttention needed from Robert Griesemer Mark Freeman added 6 comments Patchset-level comments File-
5:06 PM
Quim Muntal (Gerrit), Damien Neil (Gerrit)3
5:05 PM
[go] net: avoid windows hand in TestCloseWriteAttention needed from Quim Muntal Damien Neil uploaded new patchset Damien Neil uploaded patch set #2
unread,
[go] net: avoid windows hand in TestCloseWriteAttention needed from Quim Muntal Damien Neil uploaded new patchset Damien Neil uploaded patch set #2
5:05 PM
Quim Muntal (Gerrit), Damien Neil (Gerrit)4
5:04 PM
[go] net: use closesocket when closing socket os.File's on WindowsAttention needed from Alex Brainman and Quim Muntal Damien Neil voted Code-Review+2 Code-Review +2
unread,
[go] net: use closesocket when closing socket os.File's on WindowsAttention needed from Alex Brainman and Quim Muntal Damien Neil voted Code-Review+2 Code-Review +2
5:04 PM
Michael Knyszek (Gerrit), … Felix Geisendörfer (Gerrit)25
5:03 PM
[go] runtime: prevent unnecessary zeroing of large !noscan objectsAttention needed from Ian Lance Taylor and Keith Randall Michael Knyszek voted and added 3 comments
unread,
[go] runtime: prevent unnecessary zeroing of large !noscan objectsAttention needed from Ian Lance Taylor and Keith Randall Michael Knyszek voted and added 3 comments
5:03 PM