cpython: 2a1c7d0fdde6 (original) (raw)

Mercurial > cpython

changeset 103702:2a1c7d0fdde6

Issue #27866: Fix refleak in cipher_to_dict() [#27866]

Victor Stinner victor.stinner@gmail.com
date	Mon, 12 Sep 2016 12:00:23 +0200
parents	3a6917c73857
children	f860b7a775c5
files	Modules/_ssl.c
diffstat	1 files changed, 1 insertions(+), 12 deletions(-)[+] [-] Modules/_ssl.c 13

line wrap: on

line diff

--- a/Modules/_ssl.c +++ b/Modules/_ssl.c @@ -1587,12 +1587,6 @@ cipher_to_dict(const SSL_CIPHER *cipher) int aead, nid; const char *skcipher = NULL, *digest = NULL, *kx = NULL, *auth = NULL; #endif

PyObject *retval;

retval = PyDict_New();
if (retval == NULL) {
```
   goto error;[](#l1.11)
```
}

/* can be NULL */ cipher_name = SSL_CIPHER_get_name(cipher); @@ -1616,7 +1610,7 @@ cipher_to_dict(const SSL_CIPHER *cipher) auth = nid != NID_undef ? OBJ_nid2ln(nid) : NULL; #endif

retval = Py_BuildValue(

return Py_BuildValue( "{sksssssssisi"

#if OPENSSL_VERSION_1_1 "sOssssssss" @@ -1636,11 +1630,6 @@ cipher_to_dict(const SSL_CIPHER *cipher) "auth", auth #endif );

return retval;

error:
Py_XDECREF(retval);
return NULL;

} #endif