(original) (raw)

changeset: 97797:55b62e2c59f8 branch: 2.7 parent: 97776:ab1dc73fe8b5 user: Terry Jan Reedy tjreedy@udel.edu date: Wed Sep 09 02:10:10 2015 -0400 files: Lib/idlelib/idle_test/test_warning.py Lib/idlelib/idlever.py description: Issue 24199: Deprecate idlelib.idlever with a warning on import. diff -r ab1dc73fe8b5 -r 55b62e2c59f8 Lib/idlelib/idle_test/test_warning.py --- a/Lib/idlelib/idle_test/test_warning.py Tue Sep 08 09:59:02 2015 +0300 +++ b/Lib/idlelib/idle_test/test_warning.py Wed Sep 09 02:10:10 2015 -0400 @@ -68,6 +68,15 @@ 'Test', UserWarning, 'test_warning.py', 99, f, 'Line of code') self.assertEqual(shellmsg.splitlines(), f.getvalue().splitlines()) +class ImportWarnTest(unittest.TestCase): + def test_idlever(self): + with warnings.catch_warnings(record=True) as w: + warnings.simplefilter("always") + import idlelib.idlever + self.assertEqual(len(w), 1) + self.assertTrue(issubclass(w[-1].category, DeprecationWarning)) + self.assertIn("version", str(w[-1].message)) + if __name__ == '__main__': unittest.main(verbosity=2, exit=False) diff -r ab1dc73fe8b5 -r 55b62e2c59f8 Lib/idlelib/idlever.py --- a/Lib/idlelib/idlever.py Tue Sep 08 09:59:02 2015 +0300 +++ b/Lib/idlelib/idlever.py Wed Sep 09 02:10:10 2015 -0400 @@ -1,4 +1,12 @@ -"""Unused by Idle: there is no separate Idle version anymore. -Kept only for possible existing extension use.""" +""" +The separate Idle version was eliminated years ago; +idlelib.idlever is no longer used by Idle +and will be removed in 3.6 or later. Use + from sys import version + IDLE_VERSION = version[:version.index(' ')] +""" +# Kept for now only for possible existing extension use +import warnings as w +w.warn(__doc__, DeprecationWarning) from sys import version IDLE_VERSION = version[:version.index(' ')] /tjreedy@udel.edu