cpython: bd4dc351d670 (original) (raw)

Mercurial > cpython

changeset 93342:bd4dc351d670 2.7

Issue #22770: Prevent some Tk segfaults on OS X when running gui tests. When running tests in subprocesses with the regrtest -j option, a bug in Cocoa Tk can result in a Tcl segfault. Avoid the problem by forcing Tk to fully initialize as an OS X gui process before destroying the Tcl instance and creating another. (Original patch by Serhiy Storchaka) [#22770]

Ned Deily nad@acm.org
date	Sat, 01 Nov 2014 19:26:45 -0700
parents	28d18fdc52c4
children	62ce0f623154
files	Lib/test/test_support.py Misc/NEWS
diffstat	2 files changed, 4 insertions(+), 3 deletions(-)[+] [-] Lib/test/test_support.py 5 Misc/NEWS 2

line wrap: on

line diff

--- a/Lib/test/test_support.py +++ b/Lib/test/test_support.py @@ -326,12 +326,11 @@ def _is_gui_available(): reason = "cannot run without OS X gui process" # check on every platform whether tkinter can actually do anything

but skip the test on OS X because it can cause segfaults in Cocoa Tk
when running regrtest with the -j option (multiple threads/subprocesses)
if (not reason) and (sys.platform != 'darwin'):

if not reason: try: from Tkinter import Tk root = Tk()

       root.update()[](#l1.14)
       root.destroy()[](#l1.15)
   except Exception as e:[](#l1.16)
       err_string = str(e)[](#l1.17)

--- a/Misc/NEWS +++ b/Misc/NEWS @@ -277,6 +277,8 @@ Tests

Issue #21976: Fix test_ssl to accept LibreSSL version strings. Thanks to William Orr. +- Issue #22770: Prevent some Tk segfaults on OS X when running gui tests. + Build -----

cpython: bd4dc351d670 (original) (raw)

Mercurial > cpython

changeset 93342:bd4dc351d670 2.7

but skip the test on OS X because it can cause segfaults in Cocoa Tk

when running regrtest with the -j option (multiple threads/subprocesses)