cpython: e79eddcdff63 (original) (raw)

Mercurial > cpython

changeset 99848:e79eddcdff63 3.5

Issue #22995: [UPDATE] Comment out the one of the pickleability tests in _PyObject_GetState() due to regressions observed in Cython-based projects. [#22995]

Barry Warsaw barry@python.org
date	Mon, 11 Jan 2016 13:24:02 -0500
parents	a6288fe5420f
children	927fd0e14d49 ef84d21f5292 54dd5c105334
files	Misc/NEWS Objects/typeobject.c
diffstat	2 files changed, 12 insertions(+), 0 deletions(-)[+] [-] Misc/NEWS 3 Objects/typeobject.c 9

line wrap: on

line diff

--- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,6 +10,9 @@ Release date: tba Core and Builtins ----------------- +- Issue #22995: [UPDATE] Comment out the one of the pickleability tests in

_PyObject_GetState() due to regressions observed in Cython-based projects. +

Issue #25961: Disallowed null characters in the type name.
Issue #25973: Fix segfault when an invalid nonlocal statement binds a name

--- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -3866,6 +3866,14 @@ Py_LOCAL(PyObject *) } assert(slotnames == Py_None || PyList_Check(slotnames)); +#if 0

   /* 2016-01-11 barry - This clause breaks at least three packages which[](#l2.8)

      rely on Cython: kivy, pysam, and s3ql.  Cython may be doing[](#l2.9)

      something funny under the hood, but as this is clearly a regression[](#l2.10)

      and the rationale for this prohibition is suspect, I am commenting[](#l2.11)

      this out.  Perhaps it should just be removed.  See issue #22995 for[](#l2.12)

```
      details.[](#l2.13)
```

   */[](#l2.14)
   if (required) {[](#l2.15)
       Py_ssize_t basicsize = PyBaseObject_Type.tp_basicsize;[](#l2.16)
       if (obj->ob_type->tp_dictoffset)[](#l2.17)

@@ -3883,6 +3891,7 @@ Py_LOCAL(PyObject *) return NULL; } } +#endif if (slotnames != Py_None && Py_SIZE(slotnames) > 0) { PyObject *slots;