cpython: fa89fff0b52c (original) (raw)

Mercurial > cpython

changeset 103305:fa89fff0b52c

Issue #26798: Coverity complains about potential memcpy() of overlapped regions. It doesn't hurt to use memmove() here. CID 1372514 / CID 1372515. Upstream https://github.com/BLAKE2/BLAKE2/issues/32 [#26798]

Christian Heimes christian@python.org
date Thu, 08 Sep 2016 13:40:25 +0200
parents e5871ffe9ac0
children 2150eadb54c7
files Modules/_blake2/impl/blake2b-ref.c Modules/_blake2/impl/blake2b.c Modules/_blake2/impl/blake2s-ref.c Modules/_blake2/impl/blake2s.c
diffstat 4 files changed, 4 insertions(+), 4 deletions(-)[+] [-] Modules/_blake2/impl/blake2b-ref.c 2 Modules/_blake2/impl/blake2b.c 2 Modules/_blake2/impl/blake2s-ref.c 2 Modules/_blake2/impl/blake2s.c 2

line wrap: on

line diff

--- a/Modules/_blake2/impl/blake2b-ref.c +++ b/Modules/_blake2/impl/blake2b-ref.c @@ -334,7 +334,7 @@ int blake2b_final( blake2b_state *S, uin blake2b_increment_counter( S, BLAKE2B_BLOCKBYTES ); blake2b_compress( S, S->buf ); S->buflen -= BLAKE2B_BLOCKBYTES;

} blake2b_increment_counter( S, S->buflen );

--- a/Modules/_blake2/impl/blake2b.c +++ b/Modules/_blake2/impl/blake2b.c @@ -371,7 +371,7 @@ int blake2b_final( blake2b_state *S, uin blake2b_increment_counter( S, BLAKE2B_BLOCKBYTES ); blake2b_compress( S, S->buf ); S->buflen -= BLAKE2B_BLOCKBYTES;

} blake2b_increment_counter( S, S->buflen );

--- a/Modules/_blake2/impl/blake2s-ref.c +++ b/Modules/_blake2/impl/blake2s-ref.c @@ -325,7 +325,7 @@ int blake2s_final( blake2s_state *S, uin blake2s_increment_counter( S, BLAKE2S_BLOCKBYTES ); blake2s_compress( S, S->buf ); S->buflen -= BLAKE2S_BLOCKBYTES;

} blake2s_increment_counter( S, ( uint32_t )S->buflen );

--- a/Modules/_blake2/impl/blake2s.c +++ b/Modules/_blake2/impl/blake2s.c @@ -348,7 +348,7 @@ int blake2s_final( blake2s_state *S, uin blake2s_increment_counter( S, BLAKE2S_BLOCKBYTES ); blake2s_compress( S, S->buf ); S->buflen -= BLAKE2S_BLOCKBYTES;

} blake2s_increment_counter( S, ( uint32_t )S->buflen );