⚓ T210581 Use rate-limiter for cxserver (original) (raw)

Create Task

Maniphest T210581

Use rate-limiter for cxserver

Closed, ResolvedPublic

Actions

Assigned To

santhosh

Authored By

KartikMistry
Nov 28 2018, 8:23 AM

Tags

Referenced Files

None

Subscribers

Aklapper
gerritbot
KartikMistry
Nikerabbit
santhosh
Stashbot

Description

cxserver service should use rate-limiter feature available from service-runner. It should help to prevent cases like T210485.

Details

Subject Repo Branch Lines +/-
ratelimite: Update config for key and rate mediawiki/services/cxserver/deploy master +4 -4
Move the ratelimiter rate and key options to service configuration mediawiki/services/cxserver master +7 -8
Introduce rate limiting mediawiki/services/cxserver master

Customize query in gerrit

Related Objects

Search...

Status Subtype Assigned Task
Resolved santhosh T210581 Use rate-limiter for cxserver
Declined None T212417 cxserver: Set default config options in app.js

Mentioned In

T101398: cxserver: rate limiting
T209473: CX2: Communicate template exists in the target wiki but mapping could not be completed
T144467: Security review for Google MT for Content Translation
T211889: cxserver: TypeError: Cannot read property '_options' of null

Mentioned Here

rGCXS803baa469c00: Move the ratelimiter rate and key options to service configuration
T144467: Security review for Google MT for Content Translation
T209473: CX2: Communicate template exists in the target wiki but mapping could not be completed
T211889: cxserver: TypeError: Cannot read property '_options' of null
T210485: Investigate high usage of Apertium and V2 endpoint

Event Timeline

KartikMistry created this task.Nov 28 2018, 8:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2018, 8:23 AM

gerritbot subscribed.Nov 28 2018, 10:55 AM

Comment Actions

Change 476233 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Introduce rate limiting

https://gerrit.wikimedia.org/r/476233

gerritbot added a project: Patch-For-Review.Nov 28 2018, 10:55 AM

santhosh claimed this task.Nov 28 2018, 10:56 AM

santhosh triaged this task as Medium priority.

santhosh moved this task from Backlog to In Review on the Language-Team (Language-2018-October-December) board.

gerritbot added a comment.Dec 11 2018, 7:22 AM

Comment Actions

Change 476233 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Introduce rate limiting

https://gerrit.wikimedia.org/r/476233

Nikerabbit removed a project: Patch-For-Review.Dec 11 2018, 8:15 AM

Nikerabbit moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.

Comment Actions

Patch comes with a default config. Do we need to set anything in production config when deploying it?

• Petar.petkovic moved this task from Backlog to Page contents issues on the CX-cxserver board.Dec 14 2018, 11:44 AM

gerritbot added a comment.Dec 20 2018, 10:48 AM

Comment Actions

Change 480939 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Move the ratelimiter rate and key options to service configuration

https://gerrit.wikimedia.org/r/480939

gerritbot added a project: Patch-For-Review.Dec 20 2018, 10:49 AM

• Petar.petkovic moved this task from QA to In Review on the Language-Team (Language-2018-October-December) board.Dec 20 2018, 11:20 AM

gerritbot added a comment.Dec 20 2018, 11:37 AM

Comment Actions

Change 480945 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[mediawiki/services/cxserver/deploy@master] ratelimite: Update config for key and rate

https://gerrit.wikimedia.org/r/480945

gerritbot added a comment.Dec 20 2018, 12:07 PM

Comment Actions

Change 480939 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Move the ratelimiter rate and key options to service configuration

https://gerrit.wikimedia.org/r/480939

gerritbot added a comment.Dec 20 2018, 12:08 PM

Comment Actions

Change 480945 merged by jenkins-bot:
[mediawiki/services/cxserver/deploy@master] ratelimite: Update config for key and rate

https://gerrit.wikimedia.org/r/480945

• Petar.petkovic moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.Dec 20 2018, 12:41 PM

• Petar.petkovic removed a project: Patch-For-Review.

Stashbot subscribed.Dec 20 2018, 12:43 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2018-12-20T12:43:33Z] <kartik@deploy1001> Started deploy [cxserver/deploy@16f65cb]: Update cxserver to 803baa4 (T210581, T211889, T144467, T209473)

Stashbot mentioned this in T211889: cxserver: TypeError: Cannot read property '_options' of null.Dec 20 2018, 12:43 PM

Stashbot mentioned this in T144467: Security review for Google MT for Content Translation.

Stashbot mentioned this in T209473: CX2: Communicate template exists in the target wiki but mapping could not be completed.

Stashbot added a comment.Dec 20 2018, 12:48 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2018-12-20T12:48:15Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@16f65cb]: Update cxserver to 803baa4 (T210581, T211889, T144467, T209473) (duration: 04m 42s)

KartikMistry moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.Dec 21 2018, 8:07 AM

Pginer-WMF closed this task as Resolved.Dec 27 2018, 11:10 AM

KartikMistry mentioned this in T101398: cxserver: rate limiting.Jan 7 2020, 3:46 PM

KartikMistry closed subtask T212417: cxserver: Set default config options in app.js as Declined.Jul 6 2020, 2:30 PM

Log In to Comment

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits