T275336 push-subscription-manager group is sometimes available at all wikis (original) (raw)

push-subscription-manager group is sometimes available at all wikis

Closed, ResolvedPublic

Assigned To

Pppery

Authored By

Urbanecm
Feb 22 2021, 12:35 AM

Impact

Limited, just visually clutters the interface.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Use MediaWikiServices hook for push-subscription-manager changes	operations/mediawiki-config	master	+1 -1

Customize query in gerrit

Related Objects

Search...

Status	Subtype	Assigned	Task
Open	None	T275334 Changing user groups from $wgExtensionFunctions no longer works reliably
Resolved	Pppery	T275336 push-subscription-manager group is sometimes available at all wikis

Mentioned In

T387205: IP reveal groups: Rename 'checkuser-temporary-account-viewer' to not include the phrase 'checkuser'
T275334: Changing user groups from $wgExtensionFunctions no longer works reliably

Mentioned Here

rPWXH1124805499bf: Fix Python3 dup header handling. Fixes isse #229.
T387205: IP reveal groups: Rename 'checkuser-temporary-account-viewer' to not include the phrase 'checkuser'
rECHO3513c642dd53: Create push subscription manager group/right to clean up dead subs
T275334: Changing user groups from $wgExtensionFunctions no longer works reliably

Event Timeline

Urbanecm created this task.Feb 22 2021, 12:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript Feb 22 2021, 12:35 AM

Urbanecm triaged this task as Low priority.Feb 22 2021, 12:35 AM

Urbanecm mentioned this in T275334: Changing user groups from $wgExtensionFunctions no longer works reliably.Feb 24 2021, 11:56 AM

Legoktm added a project: Notifications (Echo).Aug 5 2021, 10:37 AM

Legoktm subscribed.

Comment Actions

I'm working on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/710136 to allow properly disabling groups, but I don't think the Echo extension should add this group by default. AFAICT it just allows sysadmins to manually delete a user's push subscriptions. On most wikis this will not be used since it's not enabled by default.

I propose: configuring the group and its permission explicitly in Meta-Wiki's configuration, add group messages to WikimediaMessages. Remove the group from Echo's extension.json and leave permission unassigned by default. Since you have to manually enable push notification support, sysadmins who enable it can configure the group then.

Restricted Application added a project: Growth-Team. · View Herald Transcript Aug 5 2021, 10:38 AM

Tgr moved this task from Inbox to Triaged on the Growth-Team board.Aug 6 2021, 7:49 AM

Xaosflux subscribed.May 10 2022, 6:51 PM

Comment Actions

Looks like this is back in the wilds again

MarcoAurelio subscribed.May 11 2022, 9:48 AM

Comment Actions

In T275336#7262895, @Legoktm wrote:

I propose: configuring the group and its permission explicitly in Meta-Wiki's configuration, add group messages to WikimediaMessages. Remove the group from Echo's extension.json and leave permission unassigned by default. Since you have to manually enable push notification support, sysadmins who enable it can configure the group then.

+1. If this is not needed but on Meta as documented (3513c64), probably having the group configured outside the extension sounds like a good idea until @Legoktm's proposed fix lands on MediaWiki. I guess this means removing "GroupPermissions" from extension.json but NOT AvailableRights.

Ameisenigel subscribed.Dec 24 2022, 8:57 PM

Lofhi subscribed.Jan 22 2024, 7:07 PM

Comment Actions

Still displayed.

Pppery updated the task description. (Show Details)Feb 2 2025, 4:57 AM

Pppery subscribed.

Comment Actions

Still an issue.

gerritbot added a comment.Feb 28 2025, 2:09 AM

Comment Actions

Change #1123499 had a related patch set uploaded (by Pppery; author: Pppery):

[operations/mediawiki-config@master] Use MediaWikiServices hook for push-subscription-manager changes

https://gerrit.wikimedia.org/r/1123499

gerritbot added a project: Patch-For-Review.Feb 28 2025, 2:09 AM

gerritbot added a comment.Mar 5 2025, 2:47 PM

Comment Actions

Change #1123499 merged by jenkins-bot:

[operations/mediawiki-config@master] Use MediaWikiServices hook for push-subscription-manager changes

https://gerrit.wikimedia.org/r/1123499

Stashbot mentioned this in T387205: IP reveal groups: Rename 'checkuser-temporary-account-viewer' to not include the phrase 'checkuser'.Mar 5 2025, 2:53 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2025-03-05T14:53:02Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]]

Stashbot added a comment.Mar 5 2025, 2:55 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2025-03-05T14:55:55Z] <dreamyjazz@deploy2002> dreamyjazz, pppery: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 5 2025, 3:04 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2025-03-05T15:04:08Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123499|Use MediaWikiServices hook for push-subscription-manager changes (T275336)]], [[gerrit:1124805|Unset unused IP reveal groups in properly (T387205)]] (duration: 11m 05s)

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2025, 3:31 PM

Dreamy_Jazz closed this task as Resolved.Mar 5 2025, 5:10 PM

Dreamy_Jazz assigned this task to Pppery.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits