fix: preserve SQL aliases in gRPC ResultSet serialization by robfrank · Pull Request #2858 · ArcadeData/arcadedb (original) (raw)
Summary of Changes
Hello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug where SQL column aliases were not preserved during gRPC ResultSet serialization. The core solution involves refactoring the gRPC server's serialization logic to process Result objects directly, rather than Record objects, which inherently lack alias information. Additionally, it ensures that essential metadata properties like @rid and @type are consistently included in gRPC responses, working around client-side parsing limitations. The changes are thoroughly validated with new and re-enabled integration tests, and comprehensive documentation has been added.
Highlights
- gRPC Serialization Fix: Switched gRPC result serialization from
Record-level toResult-level to correctly preserve SQL column aliases, aligning with HTTP handler behavior. - Metadata Injection: Implemented explicit injection of
@ridand@typemetadata into gRPC result properties for element-backed results, addressing client-side limitations. - Enhanced Testing: Added a new regression test (
sqlAliasesArePreservedInGrpcResultSet) to verify alias and metadata preservation, and a new integration test (GrpcServerPluginIT) for gRPC plugin behavior. - Test Infrastructure Improvement: Refactored
RemoteGrpcDatabaseRegressionTestto extendBaseGraphServerTestand removed@Disabledannotations, enabling full integration testing. - Documentation: Included a detailed markdown document (
2854-grpc-resultset-alias.md) explaining the bug, analysis, solution, and verification. Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
- Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩