fix #634: build attributes with oneListGroup and attributesGroupName by a-rasin · Pull Request #653 · NaturalIntelligence/fast-xml-parser (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@a-rasin

Don't ignore attributes when building to xml with oneListGroup and attributesGroupName enabled.

Purpose / Goal

Fixes #634

Type

Please mention the type of PR

…ttributesGroupName

Don't ignore attributes when building to xml with oneListGroup and attributesGroupName enabled.

@coveralls

Coverage Status

coverage: 98.266% (+0.006%) from 98.26%
when pulling 77f8aa3 on a-rasin:master
into 9118736 on NaturalIntelligence:master.

@amitguptagwl

Somehow this build is failing everytime.

@a-rasin

@a-rasin

@coveralls

Coverage Status

coverage: 98.175% (+0.007%) from 98.168%
when pulling 52241a4 on a-rasin:updated-oneListGroup-plus-attributes
into 931e910 on NaturalIntelligence:master.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})