Deprecate save-always input by joshmgross · Pull Request #1452 · actions/cache (original) (raw)

@joshmgross

The save-always input added in v4 is not working as intended due to post-if expressions not supporting the input context. To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5). See #1315 for more details.

This was referenced

Aug 14, 2024

yacaovsnc

yacaovsnc

@joshmgross

@joshmgross joshmgross deleted the joshmgross/deprecate-save-always branch

October 3, 2024 18:37

alkino pushed a commit to neuronsimulator/nrn that referenced this pull request

Oct 21, 2024

mkmkme pushed a commit to valkey-io/valkey-py that referenced this pull request

Feb 26, 2025

mkmkme pushed a commit to valkey-io/valkey-py that referenced this pull request

Mar 7, 2025

mkmkme pushed a commit to valkey-io/valkey-py that referenced this pull request

Mar 7, 2025

mkmkme pushed a commit to valkey-io/valkey-py that referenced this pull request

Mar 7, 2025

This was referenced

Mar 11, 2025

zultron added a commit to zultron/ghactions_cache that referenced this pull request

Jun 19, 2025

@zultron

zultron added a commit to zultron/ghactions_cache that referenced this pull request

Jun 19, 2025

@zultron

The previous commit reverts PR actions#1452, "Deprecate save-always input", and this commit fixes the "save-always" option.

The "save-always" input failed to force "post" script run because github.event.inputs refers to workflow dispatch or workflow call inputs, not the action's inputs: defined inside the action.yml, so github.event.inputs.save-always was never true.

Turns out it's hard to get the job's status inside the action as well, and there's no equivalent of the success() function. The workaround, passing job.status in as an input, was cribbed from actions/setup-java, where the job-status input is defined in action.yml 1, and passed through (in a loopy way) for retrieval from a utility function 2.

zultron added a commit to zultron/ghactions_cache that referenced this pull request

Jun 19, 2025

@zultron

The previous commit reverts PR actions#1452, "Deprecate save-always input", and this commit fixes the "save-always" option.

The "save-always" input failed to force "post" script run because github.event.inputs refers to workflow dispatch or workflow call inputs, not the action's inputs: defined inside the action.yml, so github.event.inputs.save-always was never true.

Turns out it's hard to get the job's status inside the action as well, and there's no equivalent of the success() function. The workaround, passing job.status in as an input, was cribbed from actions/setup-java, where the job-status input is defined in action.yml 1, and passed through (in a loopy way) for retrieval from a utility function 2.

zultron added a commit to zultron/ghactions_cache that referenced this pull request

Jun 19, 2025

@zultron

The previous commit reverts PR actions#1452, "Deprecate save-always input", and this commit fixes the "save-always" option.

The "save-always" input failed to force "post" script run because github.event.inputs refers to workflow dispatch or workflow call inputs, not the action's inputs: defined inside the action.yml, so github.event.inputs.save-always was never true.

Turns out it's hard to get the job's status inside the action as well, and there's no equivalent of the success() function. The workaround, passing job.status in as an input, was cribbed from actions/setup-java, where the job-status input is defined in action.yml 1, and passed through (in a loopy way) for retrieval from a utility function 2.

mmatl added a commit to ambi-robotics/cache that referenced this pull request

Jul 23, 2025

Update examples to use latest available checkout action v4.

Co-authored-by: Josh Gross joshmgross@github.com

Co-authored-by: Josh Gross joshmgross@github.com

As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line.

While at the PR review it's been identified there's a need for a space between the sentence

```
An ordered multiline string listing the prefix-matched keys,that are
used for restoring stale cache if no cache hit occurred for key.
```

where it's written as "prefix-matched keys,that are" this commit will address the review comment and introduce a space between "prefix-matched keys, that are" and change the sentence to

```
An ordered multiline string listing the prefix-matched keys, that are
    used for restoring stale cache if no cache hit occurred for key.
```

This workflow file publishes new action releases to the immutable action package of the same name as this repo.

This is part of the Immutable Actions project which is not yet fully released to the public. First party actions like this one are part of our initial testing of this feature.

The save-always input added in v4 is not working as intended due to post-if expressions not supporting the input context. To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5). See actions#1315 for more details.

Co-authored-by: Josh Gross joshmgross@github.com

Co-authored-by: Josh Gross joshmgross@github.com

Bumps braces from 3.0.2 to 3.0.3.

updated-dependencies:

Signed-off-by: dependabot[bot] support@github.com

Bumps actions/checkout from 3 to 4.

updated-dependencies:

Signed-off-by: dependabot[bot] support@github.com

Bumps actions/stale from 3 to 9.

updated-dependencies:

Signed-off-by: dependabot[bot] support@github.com

Bumps actions/setup-node from 3 to 4.

updated-dependencies:

Signed-off-by: dependabot[bot] support@github.com

Bumps github/codeql-action from 2 to 3.

updated-dependencies:

Signed-off-by: dependabot[bot] support@github.com

GitHub was spelled incorrectly 3 lines under the Understanding how to choose path section

Co-authored-by: Josh Gross joshmgross@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: todgru todgru@gmail.com Co-authored-by: P. Ottlinger ottlinger@users.noreply.github.com Co-authored-by: Oleg A. t0rr@mail.ru Co-authored-by: Josh Gross joshmgross@github.com Co-authored-by: r4mimu 52129983+fchimpan@users.noreply.github.com Co-authored-by: Soubhik Kumar Mitra 59209034+x612skm@users.noreply.github.com Co-authored-by: Bassem Dghaidi 568794+Link-@users.noreply.github.com Co-authored-by: Joel Ambass Jcambass@users.noreply.github.com Co-authored-by: mackey0225 masaki.asano0225@gmail.com Co-authored-by: Eman Resu 78693624+quatquatt@users.noreply.github.com Co-authored-by: Jan T. Sott git@idleberg.com Co-authored-by: John Wesley Walker III 81404201+jww3@users.noreply.github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: janco-absa janco.bester@absa.africa Co-authored-by: Tobbe Lundberg tobbe@tlundberg.com Co-authored-by: Alessandro Sebastiani sebbalex@users.noreply.github.com Co-authored-by: Rob Herley robherley@github.com Co-authored-by: Salman Chishti salmanmkc@GitHub.com Co-authored-by: Ben De St Paer-Gotch nebuk89@github.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})