fix: require `NODE_USE_ENV_PROXY` for proxy support by parkerbxyz · Pull Request #342 · actions/create-github-app-token (original) (raw)

Use Undici's EnvHttpProxyAgent in the shared request client so the beta branch keeps proxy support without relying on NODE_USE_ENV_PROXY or respawning the action process.

Add focused proxy tests and regenerate snapshots/dist.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

changed the base branch from main to beta

March 12, 2026 18:32

Add a real end-to-end proxy job that starts a local CONNECT proxy, runs the action with https_proxy, and asserts that traffic actually tunneled through the proxy.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Remove the extra post-action API request from the proxy workflow job so it only verifies the action succeeds and that proxy traffic occurred.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Remove the bundled runtime proxy handling and rely on Node's native env-proxy support instead.

Document the required NODE_USE_ENV_PROXY / NODE_OPTIONS setting, fail fast when proxy vars are set without native proxy support enabled, and keep proxy CI coverage on the native path.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

parkerbxyz changed the title~~Restore beta proxy env support with EnvHttpProxyAgent~~ fix: rely on native Node proxy support

Mar 13, 2026

Fold the native proxy support guard into lib/request.js so the request-related logic stays together without a separate helper file.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Make NODE_USE_ENV_PROXY=1 the only documented and enforced knob for enabling native proxy support.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

parkerbxyz changed the title~~fix: rely on native Node proxy support~~ fix!: require NODE_USE_ENV_PROXY for proxy support

Mar 13, 2026

Bump actions org workflow dependencies to their latest major versions where available.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

parkerbxyz changed the title~~fix!: require NODE_USE_ENV_PROXY for proxy support~~ fix!: require NODE_USE_ENV_PROXY for proxy support

Mar 13, 2026

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot AI review requested due to automatic review settings

March 13, 2026 05:28

parkerbxyz changed the title~~fix!: require NODE_USE_ENV_PROXY for proxy support~~ fix: require NODE_USE_ENV_PROXY for proxy support

Mar 13, 2026

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

parkerbxyz deleted the issue-134-remove-custom-proxy-functionality branch

March 13, 2026 06:18

parkerbxyz added a commit that referenced this pull request

Mar 13, 2026

BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

parkerbxyz added a commit that referenced this pull request

Mar 14, 2026

This PR switches proxy support to Node's native env-proxy handling and makes the required configuration explicit.

fail fast in both main and post when proxy configuration is present without NODE_USE_ENV_PROXY=1
document the supported proxy configuration in README.md
add regression tests for the proxy guard in both entrypoints
keep the existing successful end-to-end coverage and add a smaller proxy-specific workflow check that enables native proxy support, points https_proxy at an unreachable proxy, and asserts the action fails
update the test workflow so the same checks also run on pushes to beta

When using HTTP_PROXY or HTTPS_PROXY, set NODE_USE_ENV_PROXY=1 on the action step. If you need bypass rules, set NO_PROXY alongside them.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com (cherry picked from commit 54e58b6)

parkerbxyz added a commit that referenced this pull request

Mar 14, 2026

BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

parkerbxyz added a commit that referenced this pull request

Mar 14, 2026

BREAKING CHANGE: Custom proxy handling has been removed. If you use HTTP_PROXY or HTTPS_PROXY, you must now also set NODE_USE_ENV_PROXY=1 on the action step.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

fix: require NODE_USE_ENV_PROXY for proxy support by parkerbxyz · Pull Request #342 · actions/create-github-app-token (original) (raw)

fix: require `NODE_USE_ENV_PROXY` for proxy support by parkerbxyz · Pull Request #342 · actions/create-github-app-token (original) (raw)