[MCOMPILER-582] Automatic detection of release option for JDK < 9 by slawekjaranowski · Pull Request #228 · apache/maven-compiler-plugin (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the commit message/JIRA title it is not really clear what is changed. Maybe we can rename to Disregard release option for JDK < 9 so that this appears prominently in the release notes.
The commit message should focus on adding the IT and changing the documentation.
What do you think about commit subject and jira title - like:Automatic detection of release option for JDK < 9
of course commit message will contain description what is added.
My purpose of this change is to show new feature in release notes.
- add ITs for confirm feature
- extends documentation
Co-authored-by: Konrad Windszus kwin@apache.org
[MCOMPILER-582] Release option without profile for JDK 8 [MCOMPILER-582] Automatic detection of release option for JDK < 9
@kwin - ok, I prepare a final commit - please look if was squashed ok
kwin approved these changes Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})