Prepare for 3.4.0 release by pzygielo · Pull Request #460 · apache/maven-ear-plugin (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should say
Require <Maven 3.6.3> at least.
as the diff wrt 3.3.0?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should say
Support <Jakarta EE 11>.
as the diff wrt 3.3.0?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ... I see 11 is as additional to previous, so it is rationale 😄

@pzygielo thanks .... so I will release next version after it 😄

Thanks for checking @slawekjaranowski!

Should I push the shorter versions as I suggested? Or leave them as they are currently in this PR?

Should I push the shorter versions as I suggested? Or leave them as they are currently in this PR?

@pzygielo - please try with suggested version 😄

please try with suggested version

Done

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})