Remove unused javax.annotations dependency by elharo · Pull Request #899 · apache/maven-enforcer (original) (raw)

Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Merged

elharo

merged 1 commit into

Jul 6, 2025

Conversation

elharo marked this pull request as ready for review

June 29, 2025 14:20

PreDestroy is part of the JDK, no need to declare a separate dependency

This comment was marked as off-topic.

no need to declare a separate dependency

Why not remove javax.annotation-api from maven-enforcer-plugin/pom.xml then?

This transits from

[INFO] +- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.9.0.M2:provided
[INFO] |  +- javax.annotation:javax.annotation-api:jar:1.2:provided

so why not manage it in top-level-parent like javax.inject and other dependencies?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})