Improve performance of transitive dependency checks by harrisric · Pull Request #904 · apache/maven-enforcer (original) (raw)

Keep track of artifacts already validated during transitive dependency enforcement, so that we don't check the same ones multiple times.
In an example that I have we see the validation of ~19,000 artifacts where only ~1,300 are distinct.
This change keeps track of already checked artifacts and skips the validation.
I had tried to skip all the children of an already validated artifact but this did not achieve exactly the same result (some of the distinct artifacts no longer appeared in the validated set) and didn't actually seem to improve the performance much above the simple approach.
As Artifact (and specifically org.apache.maven.artifact.DefaultArtifact) doesn't include scope in its equals method I couldn't simply track a Set<Artifact> and created a class local to ArtifactMatcher for the purpose instead.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.