Add note about cloneProjectsTo being required for filtering by cpfeiffer · Pull Request #283 · apache/maven-invoker-plugin (original) (raw)

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MINVOKER-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MINVOKER-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).
• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

It took me a while to figure out why filtering didn't work. This happened on a maven-enforcer rule project,
so the cloneProjectsTo property was not set automatically (in contrast to maven-plugin projects).