[MPMD-379] Upgrade to use PMD 7.0.0 by default by mkolesnikov · Pull Request #144 · apache/maven-pmd-plugin (original) (raw)

Thanks for the PR!

As mentioned in the comments, I'm going to release PMD 7.0.0 tomorrow, so this PR should be updated to use the final version then (which requires some more changes).

Since the switch from PMD6 to PMD7 is a major change, that impacts end users, this needs a bit more thought: The end users might need to migrate the rulesets as well, to be PMD 7 compatible. It's not just a change of the version...

I'm personally undecided, whether it would be OK to ship such an update in a minor version of maven-pmd-plugin. We obviously did this last time with 3.9.0, when upgrading from PMD 5.x to PMD 6.0.1.

In any case, we should also add this to the docs, e.g. here:

* Upgrading Notes
<Note:> Starting with PMD 6.0.0 and Maven PMD Plugin 3.9.0, the rules have been reorganized
into categories, e.g. <<</category/java/bestpractices.xml>>>. So when upgrading to
Maven PMD Plugin 3.9.0 you should review your plugin configuration and/or custom ruleset.
See {{{./examples/usingRuleSets.html}Using Rule Sets}} for more information.

Since there is already a solution on how to use maven-pmd-plugin with PMD 7 (see pmd/pmd#4478), which will also work with the final PMD 7.0.0 release, there is no pressure to hurry this upgrade. MPMD-379 should be maybe renamed to be "Upgrade to use PMD 7.0.0 by default".

For what's worth, my previous work on this topic: