[MRELEASE-1109] Support CI friendly versions by kwin · Pull Request #198 · apache/maven-release (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
| AbstractRewritePomsPhase.extractPropertyFromExpression(versionElement.getTextNormalize()); |
|---|
| Properties properties = getProperties(); |
| if (properties != null) { |
| properties.computeIfPresent(ciFriendlyPropertyName, (k, v) -> version); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unimplemented (stub) method call, it does nothing.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Regular expression pattern matching Maven expressions (i.e. references to Maven properties). |
|---|
| * The first group selects the property name the expression refers to. |
| */ |
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+)\\}"); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would fail in case of <version>${revision}${sha1}${changelist}</version>, looks like the revision the only property from CI Friendly is supported right now.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})