[SUREFIRE-2095] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true when run with failsafe by br0nstein · Pull Request #545 · apache/maven-surefire (original) (raw)

When maven.test.failure.ignore is enabled, a test that crashes the JVM (e.g. that causes an OOM, with -XX:+CrashOnOutOfMemoryError) currently does not cause a build failure. This is perhaps the right behavior but is an issue in a CI setting because the following:

1. No failsafe-reports/TEST-*.xml file is created that corresponds to the test that crashed.
2. No failsafe-reports/TEST-*.xml files are created for all the tests that did not run (because they were to run after the crashed test in that same forked process).
   Because of that, in a Jenkins setting, the Jenkins Junit plugin does not identify any test failures and the build is marked successful instead of unstable. The forked process crash is only identified in the failsafe-summary XML (in the failureMessage) which AFAIK the Junit plugin does not parse to drive the build status.

This PR ensures that whether test failures are configured to be ignored or not, such a crash in the forked process by the failsafe plugin will always fail the build, to match the new behavior for the surefire plugin in SUREFIRE-1426.

This PR updates the VerifyMojo to pass a SurefireBooterForkException (deserialized from the failureMessage output to the summary XML from the IntegrationTestMojo run prior) to reportExecution so the build is terminated with a MojoExecutionException the same way as it is when tests are run by the surefire plugin (AbstractSurefireMojo).

See 6e60b03 for the corresponding fix for the surefire plugin (SUREFIRE-1426), that this leverages.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.