Enable Github Issues by Bukama · Pull Request #2413 · apache/maven (original) (raw)
- Release and Milestones already there
| This may not always be possible but is a best-practice. |
|---|
| - [ ] Run `mvn verify` to make sure basic checks pass. |
| A more thorough check will be performed on your pull request automatically. |
| - [ ] You have run the integration tests successfully (`mvn -Prun-its verify`). |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Comment on lines +47 to +48
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other files seem to end without empty line.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR template can be updated later, especially to according of integration testing
Created apache/maven-site#808 for that.
Feel free to provide notes :)
I only had issue-management.md (see site-800) on the radar so far, which is done, when I merge this PR and the according site-PR (to update links) later
PR template can be updated later, especially to according of integration testing
And the outstanding discussion about switching it to "maybe a bot command" (I mean the related discussion opened by Hervé in gh-actions-shared)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})