[SSHD-1237] Handle keep-alive channel requests by tomaswolf · Pull Request #492 · apache/mina-sshd (original) (raw)

@tomaswolf

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Handle these channel requests in the "last-resort" channel request handler.

@gnodet

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Do not log a warning about such requests, simply send back a failure reply. OpenSSH just expects any reply, whether success or failure.

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

@tomaswolf

OpenSSH sends keep-alive requests as channel requests if a channel is open. It uses a global request only if no channel is open. Handle these requests in the "last-resort" channel request handler.

@tomaswolf

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

Done.

@tomaswolf tomaswolf changed the title[SSHD-1237] Don't warn about keep-alive channel requests [SSHD-1237] Handle keep-alive channel requests

Apr 28, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})