WW-5293 Allow loading XML configuration from other than filesystem by kusalk · Pull Request #668 · apache/struts (original) (raw)

Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

WW-5293

I've split XmlConfigurationProvider into a superclass XmlDocsConfigurationProvider. The original XmlConfigurationProvider now extends XmlDocsConfigurationProvider to provide filesystem specific loading functionality. The new XmlDocsConfigurationProvider can be instantiated on its own by feeding in a parsed XML document directly.

Additionally:

Deprecated some old constructors/methods so that they can be safely deleted in Struts 7.0
Allowed greater flexibility in subclassing by splitting the build action/interceptor/result configs into their own methods
Fixed a minor existing bug where #registerBeanSelection did not respect the ObjectFactory configured class loader
Fixed a minor bug introduced in WW-5279 Improve readability of XmlConfigurationProvider class #657 where an unhandled exception is thrown when calling #loadPackages of an XmlConfigurationProvider of an already loaded XML file

…tConfig from #buildResults

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kusalk deleted the xml-config-provider-versatile branch

May 23, 2023 05:30

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})