WW-5301 Fix custom VelocityManager bean selection by kusalk · Pull Request #687 · apache/struts (original) (raw)

lukaszlenart

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question

public static final String MULTIPART_FORM_DATA_REGEX = "^multipart/form-data(?:\\s*;\\s*boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?(?:\\s*;\\s*charset=[a-zA-Z\\-0-9]{3,14})?";
private static final String CONFIG_SPLIT_REGEX = "\\s*,\\s*";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

init_CustomConfigurationProviders(); // [5]
init_FilterInitParameters(); // [6]
init_AliasStandardObjects(); // [7]
init_DeferredXmlConfigurations();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do you plan document this functionality in the docs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.