Use fallback settings when indexing the project by dhruvmanila · Pull Request #12362 · astral-sh/ruff (original) (raw)

Summary

This PR updates the settings index building logic in the language server to consider the fallback settings for applying ignore filters in WalkBuilder and the exclusion via exclude / extend-exclude.

This flow matches the one in the ruff CLI where the root settings is built by (1) finding the workspace setting in the ancestor directory (2) finding the user configuration if that's missing and (3) fallback to using the default configuration.

Previously, the index building logic was being executed before (2) and (3). This PR reverses the logic so that the exclusion / respect_gitignore is being considered from the default settings if there's no workspace / user settings. This has the benefit that the server no longer enters the .git directory or any other excluded directory when a user opens a file in the home directory.

Related to #11366

Test plan

Opened a test file from the home directory and confirmed with the debug trace (removed in #12360) that the server excludes the .git directory when indexing.