chore(deps): bump to eslint9+ and remove eslint-config-google by thomasrockhu-codecov · Pull Request #1591 · codecov/codecov-action (original) (raw)
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 93.13%. Comparing base (b9fd7d1) to head (a3de2a0).
Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1591 +/- ##
Coverage 91.94% 93.13% +1.19%
Files 5 5
Lines 335 335
Branches 78 78- Hits 308 312 +4
- Misses 27 23 -4
| Flag | Coverage Δ | |
|---|---|---|
| demo | 93.13% <ø> (+1.19%) | ⬆️ |
| macos-latest | 93.13% <ø> (+1.19%) | ⬆️ |
| script | 93.13% <ø> (+1.19%) | ⬆️ |
| ubuntu-latest | 93.13% <ø> (+1.19%) | ⬆️ |
| version | 93.13% <ø> (+1.19%) | ⬆️ |
| windows-latest | 93.13% <ø> (+1.19%) | ⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Was working on #1524 and noticed that all the formatting rules were gone. Was that intentional, or did you forget to migrate to eslint-stylistic?
Also, you don't need flatcompat, spreading imports should be fine for your usecase.
Lastly, typescript-eslint published a typescript-eslint that's the preferred import nowadays.
@lishaduck I wish I had known this so much earlier, thanks for all the info!
That said, we are moving to a bash script in the next release and thus the js/ts stuff will be all going away. Let me know if that makes sense.
We are moving to a bash script in the next release and thus the js/ts stuff will be all going away.
Yay! Dropping Node is always good 🙃 I assume it's to speed it up more, but may I request that you fix #770/#1582 while you're at it b/c (if quoted right) it should just expand with native bash globs, right?
@lishaduck ahhh, yes I'll add that to the priority list post release next week
vbraun pushed a commit to vbraun/sage that referenced this pull request
vbraun pushed a commit to vbraun/sage that referenced this pull request
vbraun pushed a commit to vbraun/sage that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})