fix: update tokenless branch logic by thomasrockhu-codecov · Pull Request #1650 · codecov/codecov-action (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings.

I am not sure where did full_name come from. This event variable does not exist in the documentation, and it is also not outputting anything when I am testing it in my repositories (not forks).

And due to that fact, the following check here:
if [ -z "$CC_BRANCH" ] && [ -z "$CODECOV_TOKEN" ] && [ "${GITHUB_EVENT_PULL_REQUEST_REPO_FULL_NAME}" != "$GITHUB_REPOSITORY"
is always false when I am upgrading to codecov-action v5, which leads to some side effects with the token check.

So, unless I am missing something, I think it is a bug.

Best,
Rust