Restore AbstractCompiler#getLogger() method by slawekjaranowski · Pull Request #334 · codehaus-plexus/plexus-compiler (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

codehaus-plexus / plexus-compiler Public

Additional navigation options

Merged

slawekjaranowski

merged 1 commit into

masterfrom

restore-get-logger

Dec 13, 2023

ConversationCommits (1)ChecksFiles changed

Merged

Restore AbstractCompiler#getLogger() method#334

slawekjaranowski

merged 1 commit into

masterfrom

restore-get-logger

Conversation

@slawekjaranowski

@slawekjaranowski slawekjaranowski commented

Dec 13, 2023

Copy link Copy Markdown

Member

We need preserve a compatibility for some time.

API was braked in 2ed77f5

@slawekjaranowski

`[Restore AbstractCompiler#getLogger() method](/codehaus-plexus/plexus-compiler/pull/334/commits/eaa1cd1ad0852e701a13f162233fba14b3d35348 "Restore AbstractCompiler#getLogger() method

We need preserve a compatibility for some time.") `

[eaa1cd1](/codehaus-plexus/plexus-compiler/pull/334/commits/eaa1cd1ad0852e701a13f162233fba14b3d35348)

We need preserve a compatibility for some time.

@slawekjaranowski slawekjaranowski requested a review from slachiewicz

December 13, 2023 18:43

@slawekjaranowski slawekjaranowski linked an issue

Dec 13, 2023

that may beclosed by this pull request

2.14.0 plexus-compiler-eclipse fails with An API incompatibility was encountered#333

Closed

@slawekjaranowski slawekjaranowski added the bug label

Dec 13, 2023

slachiewicz

slachiewicz approved these changes Dec 13, 2023

View reviewed changes

olamy

olamy approved these changes Dec 13, 2023

View reviewed changes

@olamy

olamy commented

Dec 13, 2023

Copy link Copy Markdown

Member

probably deserve a release ASAP

slawekjaranowski reacted with thumbs up emoji

@slawekjaranowski

slawekjaranowski commented

Dec 13, 2023

Copy link Copy Markdown

Member Author

probably deserve a release ASAP

Yes I will it today

@slawekjaranowski slawekjaranowski merged commit 3ab39cd into master

Dec 13, 2023

@slawekjaranowski slawekjaranowski deleted the restore-get-logger branch

December 13, 2023 22:18

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@olamy olamy olamy approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2.14.0 plexus-compiler-eclipse fails with An API incompatibility was encountered

3 participants

@slawekjaranowski @olamy @slachiewicz