Only use "-release" parameter with javac 9+ by kwin · Pull Request #362 · codehaus-plexus/plexus-compiler (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

codehaus-plexus / plexus-compiler Public

• Notifications You must be signed in to change notification settings

• Fork62

• Star 37

• Code

• Issues 11

• Pull requests 2

• Discussions

• Actions

• Security and quality

• Insights

Additional navigation options

Merged

kwin

merged 1 commit into

masterfrom

feature/set-release-conditionally

Feb 5, 2024

ConversationCommits (1)ChecksFiles changed

Merged

Only use "-release" parameter with javac 9+#362

kwin

merged 1 commit into

masterfrom

feature/set-release-conditionally

Conversation

kwin commented

Feb 3, 2024

Copy link Copy Markdown

Contributor

This closes #140

`[Only use "-release" parameter with javac 9+](/codehaus-plexus/plexus-compiler/pull/362/commits/69496455fcab14668a65ad9e6816247ba5cc6a75 "Only use "-release" parameter with javac 9+

This closes #140") `

[6949645](/codehaus-plexus/plexus-compiler/pull/362/commits/69496455fcab14668a65ad9e6816247ba5cc6a75)

This closes #140

kwin requested review fromgnodet and slawekjaranowski

February 3, 2024 10:16

slachiewicz approved these changes Feb 3, 2024

View reviewed changes

slawekjaranowski approved these changes Feb 3, 2024

View reviewed changes

gnodet commented

Feb 3, 2024

•

edited

Loading

Copy link Copy Markdown

Member

Does this mean you cannot have a single configuration that would target JDK 8 and built on both JDK 8 and JDK 11 ?

kwin commented

Feb 3, 2024

Copy link Copy Markdown

Contributor Author

The other way around:
Right now you cannot use "release" with javac 8 (leads to an error), in the future it will be silently disregarded. This makes JDK9+ specific profiles like https://github.com/apache/maven-apache-parent/blob/4e05486793fa7938cb4de7eff04d54ceae05f9d3/pom.xml#L528-L538 obsolete.

gnodet reacted with thumbs up emoji

slawekjaranowski added the enhancement label

Feb 5, 2024

kwin merged commit d8e98dd into master

Feb 5, 2024

kwin deleted the feature/set-release-conditionally branch

February 5, 2024 09:44

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

slawekjaranowski slawekjaranowski approved these changes

slachiewicz slachiewicz approved these changes

gnodet Awaiting requested review from gnodet

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"release" parameter should only be set for javac version >= 9

4 participants