Fix detecting java version for JDK 1.8 by slawekjaranowski · Pull Request #462 · codehaus-plexus/plexus-compiler (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
codehaus-plexus / plexus-compiler Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
masterfrom
Nov 23, 2025
ConversationCommits (1)ChecksFiles changed
Merged
Fix detecting java version for JDK 1.8#462
merged 1 commit into
masterfrom
Conversation
Copy link Copy Markdown
Member
No description provided.
[Fix detecting java version for JDK 1.8](/codehaus-plexus/plexus-compiler/pull/462/commits/3527cc4768ceb809f0a59317f547dd281e7bfd27 "Fix detecting java version for JDK 1.8")
[3527cc4](/codehaus-plexus/plexus-compiler/pull/462/commits/3527cc4768ceb809f0a59317f547dd281e7bfd27)
that may beclosed by this pull request
JavacCompiler fails to resolve version with maven toolchains and Jenkins#420
Closed
slachiewicz approved these changes Nov 11, 2025
nxglhez commented
Copy link Copy Markdown
As I said in #420, you should probably go from last to first line: you could inject a javac prefix (I don't say these are real use case):
# with java 21
$ JAVA_TOOL_OPTIONS="-Duser.language=en -Dfoobar='"$'\n'"javac 1.8.0_462"$'\n'"'" javac -version > /dev/null
Picked up JAVA_TOOL_OPTIONS: -Duser.language=en -Dfoobar='
javac 1.8.0_462
'
The code that's responsible for those messages does not escape anything: https://github.com/openjdk/jdk/blob/400a83da893f5fc285a175b63a266de21e93683c/src/hotspot/share/runtime/arguments.cpp#L3160
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
JavacCompiler fails to resolve version with maven toolchains and Jenkins
3 participants
