Fix #16: StringSearchInterpolator does not cache answers. by belingueres · Pull Request #17 · codehaus-plexus/plexus-interpolation (original) (raw)

Skip to content

Navigation Menu

• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

• Added tests exposing the issue.
• Fixed code.
• Added missing @OverRide annotations.

That looks great, but could you separate the fix of override and the test into separate pull request...I appreciate to merge that...Thanks for helping..

Do you mean only the extra @OverRide in another PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the conflicts will have to be solved before merging obviously.

• Added tests exposing the issue.
• Fixed code.
• Added missing @OverRide annotations.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels