Allow to customize Plexus container by test class by slawekjaranowski · Pull Request #91 · codehaus-plexus/plexus-testing (original) (raw)

@slawekjaranowski

@slawekjaranowski

@sparsick

@slawekjaranowski

Tested with ModelloConvertersMojoTest from modello project. And it works like a charm. 👍

One suggestion: I would add a sentence that the interface also has a method for customizing the configuration.

@slawekjaranowski

@slawekjaranowski

Tested with ModelloConvertersMojoTest from modello project. And it works like a charm. 👍

One suggestion: I would add a sentence that the interface also has a method for customizing the configuration.

Please point where do you want add such sentence.

sparsick

private TestJavaxComponent2 mockComponent2;
@Override
public void customizeContainer(PlexusContainer container) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add here a comment that another customize method exists

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sparsick done ... and docs also updated

@slawekjaranowski

sparsick

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})