chore: avoid use of parent pom and maven properties where unnecessary by chadlwilson · Pull Request #8322 · dependency-check/DependencyCheck (original) (raw)
changes to core
changes to the maven plugin
changes to utils
labels
chore: avoid use of parent pom and maven properties where it is unnec… chore: avoid use of parent pom and maven properties where it is unnecessary
chore: avoid use of parent pom and maven properties where it is unnecessary chore: avoid use of parent pom and maven properties where unnecessary
…essary
Using properties adds confusing indirection to dependencies when tracking things down; plugin management already serves this purpose, so I suggest should reserve use for cases where we want to de-duplicate versions (even though dependabot can help us with this anyway) or add clarity for coupled versions via the properties.
Additionally, it is clearer to manage dependencies for the maven plugin in its own dependencyManagement since this has no effect on the rest of ODC, and doesn't need a parent POM reference.
Signed-off-by: Chad Wilson 29788154+chadlwilson@users.noreply.github.com
This is a provided dependency alongside the API version; so don't think we need to actively manage this now. Was originally added in 081d21d to address a conflict which seems to no longer exist.
Signed-off-by: Chad Wilson 29788154+chadlwilson@users.noreply.github.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})