Dockerfile: update golangci-lint to v2.10.1 by thaJeztah · Pull Request #6826 · docker/cli (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@thaJeztah

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vvoland

Need to fix the linter failures

@thaJeztah

yup; saw those, and decided to leave it for a later exercise 😆

@vvoland

I went ahead and pushed a commit to unblock the CI.

thaJeztah

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

LOL; can't approve it myself; and maybe you won't be able to either because you last pushed, but can you give it a try @vvoland ?

vvoland

@vvoland

Heh, I can approve, but not merge 😅

@thaJeztah

Let me try if I push again.

@thaJeztah

Signed-off-by: Sebastiaan van Stijn github@gone.nl

@vvoland @thaJeztah

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

@thaJeztah

can you try approving again? 😂 🫠

vvoland

@vvoland

image

@vvoland

Feel free to squash and reset the commit author so it doesn't see me 😅

@thaJeztah

But they were not; I pushed! 😂

robmry

@thaJeztah

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels