[release/8.0][wasm] Fix perf pipeline runs by radical · Pull Request #93888 · dotnet/runtime (original) (raw)

@LoopedBard3 @radical

LoopedBard3

@radical

@radical

carlossanlop

@radical radical changed the title[releaes/8.0][wasm] Fix perf pipeline runs [release/8.0][wasm] Fix perf pipeline runs

Oct 23, 2023

@radical

lewing added a commit that referenced this pull request

Oct 28, 2023

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-rtm.23511.3 -> To Version 8.0.0-rtm.23520.2

This reverts commit 768b65b.


Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing lewing@microsoft.com


Co-authored-by: Viktor Hofer viktor.hofer@microsoft.com

UnmanagedMemoryStream used Interlocked operations to update its state to prevent tearing of 64-bit values on 32-bit platforms. This pattern is expensive in general and it was found to be prohibitively expensive on recent hardware..

This change removes the expensive Interlocked operations and addresses the tearing issues in alternative way:

Fixes #93624


Co-authored-by: Jan Kotas jkotas@microsoft.com

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100 From Version 8.0.0-rtm.23520.2 -> To Version 8.0.0-rtm.23523.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3


Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

(cherry picked from commit a770017)


Co-authored-by: Parker Bibus parkerbibus@microsoft.com

Co-authored-by: Jeff Handley jeffhandley@users.noreply.github.com


Co-authored-by: Eirik Tsarpalis eirik.tsarpalis@gmail.com Co-authored-by: Jeff Handley jeffhandley@users.noreply.github.com


Co-authored-by: Carlos Sánchez López 1175054+carlossanlop@users.noreply.github.com Co-authored-by: Larry Ewing lewing@microsoft.com Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer viktor.hofer@microsoft.com Co-authored-by: Alexander Köplinger alex.koeplinger@outlook.com Co-authored-by: Jan Kotas jkotas@microsoft.com Co-authored-by: Ankit Jain radical@gmail.com Co-authored-by: Parker Bibus parkerbibus@microsoft.com Co-authored-by: Eirik Tsarpalis eirik.tsarpalis@gmail.com Co-authored-by: Jeff Handley jeffhandley@users.noreply.github.com

@ghost ghost locked as resolved and limited conversation to collaborators

Nov 24, 2023

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})