Merging internal commits for release/9.0 by vseanreesermsft · Pull Request #109744 · dotnet/runtime (original) (raw)

and others added 30 commits

August 28, 2024 15:50

@rzikm

@rzikm

@rzikm

Description

Use explicit full-path for loading MsQuic.dll - it prevents accidental load of MsQuic.dll from another unintended directory (e.g. CWD = Current Working Directory) if the bundled MsQuic.dll fails to load (which can happen e.g. on WinServer 2012, where MsQuic is not supported).

Customer Impact

Defense-in-depth

Regression

No

Testing

Targeted manual test on affected OS (Windows Server 2012), including self-contained and single-file publish scenarios.

Risk

Low, changes are contained and have been thoroughly tested manually and in CI suite.

@jeffhandley

…bstract array types

Jagged arrays in the payload can contain cycles. In that scenario, no value is correct for ArrayRecord.FlattenedLength, and ArrayRecord.GetArray does not have enough context to know how to handle the cycles. To address these issues, jagged array handling is simplified so that calling code can handle the cycles in the most appropriate way for the application.

Single-dimension arrays can be represented in the payload using abstract types such as IComparable[] where the concrete element type is not known. When the concrete element type is known, ArrayRecord.GetArray could return either SZArrayRecord<ClassRecord> or SZArrayRecord<object>; without a concrete type, we need to return something that represents the element abstractly.

  1. ArrayRecord.FlattenedLength is removed from the API
  2. ArrayRecord.GetArray now returns ArrayRecord[] for jagged arrays instead of trying to populate them
  3. ArrayRecord.GetArray now returns SZArrayRecord<SerializationRecord> for single-dimension arrays instead of either SZArrayRecord<ClassRecord> or SZArrayRecord<object>

Mirroring and others added 18 commits

October 16, 2024 17:30

@elinor-fung @carlossanlop

A call to Assembly.Location was added in a recent fix. It has IL30000 suppressed via #pragma warning disable, but that only applies to the compilation of the library itself. Consumers will hit it when doing something like publishing their app as NativeAOT.

This change adds an [UnconditionalSuppressMessage] to the MsQuicApi static constructor such that IL30000 should also be suppressed for apps consuming the runtime.

This was caught in an aspnetcore deps flow PR coming from runtime.

@vseanreesermsft

…-merge-9.0-2024-11-12-1248

carlossanlop

This was referenced

Nov 12, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})