Do not silently fail in case of class scanning exceptions by kwin · Pull Request #98 · eclipse-sisu/sisu-project (original) (raw)
@cstamas Any idea how to make this configurable from Maven? Do we really want to extend the Plexus Container API for that?
| try |
|---|
| { |
| new SpaceScanner( _space ).accept( this ); |
| new SpaceScanner( _space, true ).accept( this ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess being always strict here should be fine
| void scanForElements( final Binder binder ) |
|---|
| { |
| new SpaceScanner( space, finder ).accept( strategy.visitor( binder ) ); |
| new SpaceScanner( space, finder, true ).accept( strategy.visitor( binder ) ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably expose a way on how to toggle the strict flag.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default mode should remain non-strict, for reasons discussed in #97 (comment)
We can still change the mode to strict when generating the index via annotation processing or the maven plugin. That should solve the main build-time issue without affecting runtime deployments.
@mcculls Can you comment on the individual cases listed above?
SisuIndex can be strict by default because it's build-time - everything else should be non-strict by default, with an option to make them strict.
everything else should be non-strict by default, with an option to make them strict.
@mcculls done now, can you check again?
If there are no further concerns @mcculls I am gonna merge end of this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})