Fix DiffThunkRange access by cklin · Pull Request #2620 · github/codeql-action (original) (raw)

Skip to content

Navigation Menu

• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

cklin

merged 1 commit into

Dec 2, 2024

Conversation

This PR fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Confirm the readme has been updated if necessary.
• Confirm the changelog has been updated if necessary.

[](/apps/github-advanced-security)

This commit fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.

cklin marked this pull request as ready for review

November 21, 2024 22:05

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 🧹

cklin deleted the cklin/DiffThunkRange-fix branch

December 2, 2024 15:31

This was referenced

Dec 3, 2024

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})