Python: Disable standard library extraction on GHES by henrymercer · Pull Request #3794 · github/codeql-action (original) (raw)
This has been the CLI default for some time now that Python analysis contains models of the standard library. However due to the default value of the feature flag we have been manually enabling standard library extraction on GHES.
This PR cleans up that feature and removes the override logic.
Risk assessment
For internal use only. Please select the risk level of this change:
- Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
Which use cases does this change impact?
Workflow types:
- Advanced setup - Impacts users who have custom CodeQL workflows.
- Managed - Impacts users with
dynamicworkflows (Default Setup, Code Quality, ...).
Products:
- Code Scanning - The changes impact analyses when
analysis-kinds: code-scanning. - Code Quality - The changes impact analyses when
analysis-kinds: code-quality. - Other first-party - The changes impact other first-party analyses.
Environments:
- GHES - Impacts CodeQL workflows on GitHub Enterprise Server.
How did/will you validate this change?
- None - I am not validating these changes.
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
- Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.
How will you know if something goes wrong after this change is released?
If there's a subtle bug here, we'd realistically probably only catch it in the release QA process.
Are there any special considerations for merging or releasing this change?
- No special considerations - This change can be merged at any time.