Improve connection tests by mbg · Pull Request #3853 · github/codeql-action (original) (raw)

A few minor improvements to the private registry connection checks:

Use GET instead of HEAD requests, for better compatibility. Some registries don't like HEAD requests. We still call res.destroy() immediately after inspecting the status code, so never read the response body. So using GET over HEAD should have a minimal impact on performance.
For NuGet feeds, we now test the service index instead of the base URL. The service index should always be present and is more reliable than making a request to the base URL.
Some logging improvements.

For internal use only. Please select the risk level of this change:

Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Workflow types:

Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
Code Quality - The changes impact analyses when analysis-kinds: code-quality.
Other first-party - The changes impact other first-party analyses.

Environments:

Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

Telemetry - I rely on existing telemetry or have made changes to the telemetry.
- Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
- Alerts - New or existing monitors will trip if something goes wrong with this change.