feat: add an option to verify with the JSONSchema by ldez · Pull Request #1167 · golangci/golangci-lint-action (original) (raw)

Hi! Thanks for baking this into the action! Much appreciated.

But, I think, there's an omission as the --config flag isn't passed to verify. Relevant excerpt from our logs:

Running [/home/runner/golangci-lint-1.64.5-linux-amd64/golangci-lint config verify] in [/home/runner/work/workflows/workflows/lintapp] ...
Running [/home/runner/golangci-lint-1.64.5-linux-amd64/golangci-lint run --path-prefix=lintapp --config=../.golangci.yml] in [/home/runner/work/workflows/workflows/lintapp] ...
golangci-lint found no issues
Ran golangci-lint in 13865ms

If --config is provided to run, then the same value should be extracted from the run args and passed to verify, but https://github.com/ldez/golangci-lint-action/blob/594fb07c1e4c07cf5aca70f6775681cf2a580d44/src/run.ts#L141 defines the command as a static string (apologies if that's not the case, not very comfortable reading node code).