feat: enable flag for report generation by jinseopkim0 · Pull Request #1991 · googleapis/java-datastore (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Conversation

@jinseopkim0

@jinseopkim0

lqiu96

Comment on lines 63 to 66

org.codehaus.mojo
clirr-maven-plugin
true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CLIRR should be enabled by default via shared-configs. Can you double check if we can just delete this entire block?

lqiu96

lqiu96 previously approved these changes Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Added a small note about CLIRR being default on (this was the last from when I last looked into it and may have changed).

@jinseopkim0

lqiu96

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

api: datastore

Issues related to the googleapis/java-datastore API.

size: xs

Pull request size is extra small.

2 participants

@jinseopkim0 @lqiu96