[Fix] order: do not compare first path segment for relative paths by mihkeleidast · Pull Request #2885 · import-js/eslint-plugin-import (original) (raw)
Conversation
Should fix the regression in #2682.
The gist of the fix is that for relative paths, siblings always start with "." and parents always start with "..". When comparing them, it will always result in "." being first, which was the bug. The sorting based on subpath segments should start from the second path segment, when there is a possibility that one of them is different.
fix(import/order): do not compare first sibling and parent path segment fix(import/order): do not compare first path segment for relative paths
Can you add the exact test case from the OP of #2682?
@ljharb added! This was a good suggestion, as that particular case needed additional handling.
Not sure what is going on with the failing actions, do not seem related to my changes?
Hi everyone, do you reckon this PR has a reason to be blocked? Like a lot of people, I've been sticking with v2.26.0 of this plugin since #2682 has been a thing, and I'd very much like to get back to being up-to-date and with imports in the right order 😉
Any news here? PR looks fine, any blockers I can help getting rid of?
Any news here? PR looks fine, any blockers I can help getting rid of?
I think while my fix does work for some of the reported issues, some would still not be fixed by this, e.g. #2722
I could not fix the other issues, so gave up as it does not affect my usecases as much. But probably would help if the fix would resolve all of the different issues that have been reported.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as existing tests pass :-)
fix(import/order): do not compare first path segment for relative paths [Fix] order: do not compare first path segment for relative paths
renovate Bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request
| datasource | package | from | to |
|---|---|---|---|
| npm | eslint-plugin-import | 2.29.1 | 2.30.0 |
v2.30.0
Added
- [
dynamic-import-chunkname]: addallowEmptyoption to allow empty leading comments ([#2942], thanks [@JiangWeixian]) - [
dynamic-import-chunkname]: Allow empty chunk name when webpackMode: 'eager' is set; add suggestions to remove name in eager mode ([#3004], thanks [@amsardesai]) - [
no-unused-modules]: AddignoreUnusedTypeExportsoption ([#3011], thanks [@silverwind]) - add support for Flat Config ([#3018], thanks [@michaelfaith])
Fixed
- [
no-extraneous-dependencies]: allow wrong path ([#3012], thanks [@chabb]) - [
no-cycle]: use scc algorithm to optimize ([#2998], thanks [@soryy708]) - [
no-duplicates]: Removing duplicates breaks in TypeScript ([#3033], thanks [@yesl-kim]) - [
newline-after-import]: fix considerComments option when require ([#2952], thanks [@developer-bandi]) - [
order]: do not compare first path segment for relative paths ([#2682]) ([#2885], thanks [@mihkeleidast])
Changed
- [Docs]
no-extraneous-dependencies: Make glob pattern description more explicit ([#2944], thanks [@mulztob]) - [
no-unused-modules]: add console message to help debug [#2866] - [Refactor]
ExportMap: make procedures static instead of monkeypatching exportmap ([#2982], thanks [@soryy708]) - [Refactor]
ExportMap: separate ExportMap instance from its builder logic ([#2985], thanks [@soryy708]) - [Docs]
order: Add a quick note on how unbound imports and --fix ([#2640], thanks [@MinervaBot]) - [Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) ([#2987], thanks [@joeyguerra])
- [actions] migrate OSX tests to GHA ([ljharb#37], thanks [@aks-])
- [Refactor]
exportMapBuilder: avoid hoisting ([#2989], thanks [@soryy708]) - [Refactor]
ExportMap: extract "builder" logic to separate files ([#2991], thanks [@soryy708]) - [Docs] [
order]: update the description of thepathGroupsExcludedImportTypesoption ([#3036], thanks [@liby]) - [readme] Clarify how to install the plugin ([#2993], thanks [@jwbth])
This was referenced
Sep 26, 2024
This was referenced
Oct 3, 2024
This was referenced
Oct 4, 2024
This was referenced
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})