fix(visitor): record string occurrence for accurate position reporting by TobyTheHutt · Pull Request #49 · jgautheron/goconst (original) (raw)

Fix string position tracking so duplicate string literals report all occurrences correctly.

Previously, addString only stored positions for the first occurrence and when minOccurrences was reached, which could under-report locations. The visitor now records every occurrence while still using the existing count map for threshold checks.

Changes:

• Updated visitor.go to append a position for every matching string occurrence.
• Unit coverage in visitor_test.go with full position capture across different minOccurrences values.
• Integration coverage in integration_test.go with end-to-end position counts from testdata.

Resolves: #45