Improve message of discovery issues for ineffective @Order annotations by marcphilipp · Pull Request #4718 · junit-team/junit-framework (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@marcphilipp

@marcphilipp

sbrannen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I only suggested the use of text blocks.

sbrannen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a second-pass review.

@marcphilipp

sbrannen

@marcphilipp marcphilipp deleted the marc/4713-improve-disco-issue-message-ineffective-order-annotation branch

July 3, 2025 10:46

marcphilipp added a commit that referenced this pull request

Jul 3, 2025

@marcphilipp

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

2 participants

@marcphilipp @sbrannen