Use node test runner by sirenkovladd · Pull Request #1845 · koajs/koa (original) (raw)
Checklist
use node --test instead of jest
See: #1837 (comment)
- I have ensured my pull request is not behind the main or master branch of the original repository.
- I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
- I have written a commit message that passes commitlint linting.
- I have ensured that my code changes pass linting tests.
- I have ensured that my code changes pass unit tests.
- I have described my pull request and the reasons for code changes along with context if necessary.
| }) |
|---|
| it('should catch stream error', done => { |
| // TODO |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the TODO regarding?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, forgot to delete
| const assert = require('assert') |
|---|
| const Koa = require('../..') |
| process.env.NODE_ENV = 'test' |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is NODE_ENV now required specifically for this test?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed, moved this env to params
@sirenkovladd, thanks for all the updates! I want to check in with the more seasoned team about the removed test before moving forward. I appreciate your patience!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work!
it seems like the tests do not automatically close when I run nom test locally. any ideas why?
hmmm nevermind, it only happened once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})