[readme]: Minor change of grammar by JoBeGaming · Pull Request #550 · ljharb/qs (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

ljharb / qs Public

Additional navigation options

Merged

ljharb

merged 1 commit into

ljharb:mainfrom

JoBeGaming:main

Apr 27, 2026

ConversationCommits (1)ChecksFiles changed

Merged

[readme]: Minor change of grammar#550

ljharb

merged 1 commit into

ljharb:mainfrom

JoBeGaming:main

Conversation

@JoBeGaming

@JoBeGaming JoBeGaming commented

Mar 13, 2026

Copy link Copy Markdown

Contributor

Use imperative in README, similar to usage of such explained in the Commit Message Guidelines.

@JoBeGaming @ljharb

[[readme] fix grammar](/ljharb/qs/pull/550/commits/96755abd357c0e534dd3442a84a04d08864bfe0d "[readme] fix grammar")

[96755ab](/ljharb/qs/pull/550/commits/96755abd357c0e534dd3442a84a04d08864bfe0d)

@ljharb ljharb force-pushed the main branch from3072e1f to96755ab Compare

April 26, 2026 22:22

ljharb

ljharb approved these changes Apr 26, 2026

View reviewed changes

@ljharb ljharb left a comment

Copy link Copy Markdown

Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't about imperative or not, to be clear, this is just incorrect grammar. thanks for the fix

JoBeGaming reacted with thumbs up emoji

@ljharb ljharb added the documentation label

Apr 26, 2026

@ljharb ljharb merged commit 96755ab into ljharb:main

Apr 27, 2026

415 checks passed

@sync-by-unito sync-by-unito Bot mentioned this pull request

May 23, 2026

Bump qs from 6.14.1 to 6.15.2ForumMagnum/ForumMagnum#12531

Merged

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoBeGaming @ljharb