Soften the javadoc checks a bit by gsmet · Pull Request #135 · maveniverse/njord (original) (raw)

Conversation

A sources jar can contain .java files that are not compiled. This is for instance the case of archetypes jar and, in the specific case of Quarkus, of the codestarts jar.

Let's be less strict.

A sources jar can contain .java files that are not compiled. This is for instance the case of archetypes jar and, in the specific case of Quarkus, of the codestarts jar.

Let's be less strict.

Am not sure about this. Why not instead then parameterized "contains source WHERE?", make methods jarContainsJavaSources and jarContainsJavaClasses be able to parameterize somehow, ie. includes/excludes/globs?

At the beginning, I excluded archetype-resources but then stumbled upon the codestarts issue.

Given Central Portal let them pass and they have no knowledge or our codestarts artifact, I wouldn't be too strict.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants