fix bad text values in parse by connor4312 · Pull Request #126 · micromatch/picomatch (original) (raw)
Previously sibling text tokens would exclude the output from the first token, resulting in the referenced issues. I think this should be a fairly safe change.
Previously sibling text tokens would exclude the output from the
first token, resulting in the referenced issues. I think this should
be a fairly safe change.
Fixes micromatch#125 Fixes micromatch#100
| const expected = [ |
| ['bos', { output: '', value: '' }], |
| ['text', { output: 'foo.', value: 'foo.' }], |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just a ., which is what issue #100 referenced
| ['bos', { output: '', value: '' }], |
|---|
| ['text', { output: 'foo.', value: 'foo.' }], |
| ['paren', { output: undefined, value: '(' }], |
| ['text', { output: 'm|c |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was |c| which is what #125 referenced
Sorry for the late reply, and thanks for the PR. Reviewing now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})