Harmonize @Nullable annotations in okhttp instrumentation by jonatan-ivanov · Pull Request #7375 · micrometer-metrics/micrometer (original) (raw)

@jonatan-ivanov

This is a just firefighting and not a proper fix. The proper fix would be non-null request and nullable response but fixing that seems to be a very deep rabbit hole and also involves breaking changes.

Closes micrometer-metricsgh-7373

@jonatan-ivanov mentioned this pull request

Apr 3, 2026

shakuzen

jckoenen

shakuzen

jckoenen

jonatan-ivanov added a commit that referenced this pull request

Apr 7, 2026

@jonatan-ivanov

When gh-7375 was merged in tests were ok locally and the PR build was also fine. But after merge, it broke the build. The failure is valid, the tests did not follow the implementation, this change fixes them.

See gh-7373 See gh-7375

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})